Repository navigation
Pin the lazy-grammar pause and the Seed-OSS call-name constraint in tests - #1963
Merged
Merged
Conversation
leehack
marked this pull request as draft
November 12, 2026 18:00
17 of 20 tasks
leehack
marked this pull request as ready for review
November 12, 2026 18:16
Contributor
|
Chat app preview removed for |
This was referenced Nov 12, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
think-bodyorseed-thought(Keep the response-format grammar applied through a budgeted forced-open thought #1956 audit, mutant F).Tracks #1950; does not close it.
Production-readiness scope
Completeness checklist
PR type guidance
Mutation results
test/integration/thinking_budget_grammar_test.dart)useLazyGrammar ||inllama_cpp_service.dart</think>okfor both roots)seed_oss_handler_test.dart)tool-name ::= identifierinxml_tool_call_format.dartExpected: false, Actual: true)The old assertion lacked the closing
</seed:tool_call>, so it was rejected as incomplete under either mutation. The new input is a complete scope with the rightlocationparameter and a wrong function name (get_time).Test Plan
dart run tool/prepare_workspace.dartdart format --output=none --set-exit-if-changed .(touched files)dart analyzedart test -p vm -j 1 --exclude-tags local-only: touched files only locally (TMPDIRisolated); full lane in CIdart test -p chrome --exclude-tags local-onlyN/A, VM-only testscoverage-libN/A, nolib/changedart tool/ci/test_shards.dart hostson both files (integration: every OS; unit: Linux only)Matrix Evidence
static-format-analyzeroot-vmstructured-output-adversarialroot-chrome,coverage-liblib/changehigh-risk-exact-head-independent-qa2b51d2f5Review Notes
High-risk regression review
structuredOutput, from test paths only; no production file changes)externalPrerequisitesUnavailable)